Simple soql breaking limits

Question

I'm trying to update the account every time a contact is updated and the simplest thing seems to be blowing up.

trigger ContactAccountOriginTrigger on Contact (before insert, before Update) {
    List<Account> AccountList = new List<Account>();
    List<ID> IdList = new List<ID>();

    for (Integer i = 0; i <Trigger.new.size(); i++){
       IdList.Add(Trigger.new[i].AccountId);        
    }    

    AccountList = [SELECT Id, Name FROM Account WHERE Id in : IdList];

    for (Integer i = 0; i <Trigger.new.size(); i++){
        if (AccountList.size() > 0){
            for (Account a:AccountList){
                if(Trigger.new[i].Focus_ID__c != null || Trigger.new[i].Focus_ID__c == ''){             
                    logic
                }
                else{
                    logic
                }
                if(a.get('Id') == null) {
                    insert a;                   
                }else{
                    update a;
                }
            }
        }        
    }
}

Test Class

@isTest
public class ContactAccountOriginTest {
    static testMethod void insertNewAccount() {
        Account acctToCreate = new Account();
        Contact contToCreate = new Contact();

        acctToCreate.Name  = 'Practice Test';
        insert acctToCreate;

        //1st pass
        contToCreate.FirstName = 'test';
        contToCreate.LastName = 'test';
        contToCreate.AccountId = acctToCreate.Id;
        contToCreate.Focus_ID__c = '00001';
        insert contToCreate;
        update acctToCreate;

        //2nd pass
        contToCreate.FirstName = 'test';
        contToCreate.LastName = 'test';
        contToCreate.AccountId = acctToCreate.Id;
        contToCreate.Focus_ID__c = null;
        update contToCreate; 

        update acctToCreate;
    }
}

Answer 1

I am assuming you are trying to update the exsisting account of the contact if it has a Account else create a new Account. Below is an example of how you can update the parent based on the child:

Although, you may consider using a Process builder which can update the parent record or even create new records. Might save you writing some lines of code.

trigger ContactAccountOriginTrigger on Contact (before insert,before update) {


    List<ID> IdList = new List<ID>();
    List<Account> accToUpdateOrInsert = new List<Account>();
    for(Contact c : trigger.new){
        if(c.accountid!=Null){
        idList.add(c.accountid);   
        }else{
           Account a = new Account(Name='WhatName');
           accToUpdateOrInsert.add(a);
        }
    }

    Map<Id,Account> accountMap = new Map<Id,Account>();
    List<Account> accList = [select id,Name,(select id, Focus_ID__c from Contacts) from Account where id in:idList];
    For(Account a : accList){
      if(a.contacts.size()>0){
        For(Contact c: a.Contacts){
            accountMap.put(c.id,a);          
        }
      }

    }

    For(Contact c:trigger.new){

        if(c.Focus_ID__c!=NULL){       
        Account acnt = accountMap.get(c.id);
        // Your Logic to do whatever with the account field
        accToUpdateOrInsert.add(acnt);       
        }else{
        Account acnt = accountMap.get(c.id);
        // Your Logic to do whatever with the account field
        accToUpdateOrInsert.add(acnt); 
        }

    }

    upsert accToUpdateOrInsert;

}