Why my save function does not work?

Question

I have a custom page. When I on click save button it does not save anything. Is there anything wrong with my code that I could not find? Thanks

 public PageReference save() {
        if(controller.save() != null) {
        PageReference congratsPage = Page.pitu3;
        congratsPage.setRedirect(true);
        congratsPage.getParameters().put('id',controller.getId());
        return congratsPage;
        }return null;
    }

Answer 1

There must be some validation or system error as suggested by Keith. I would suggest to use below to show error to user or at at least use system.debug to see what is going on.

Try{
      if(controller.save() != null) {
           PageReference congratsPage = Page.pitu3;
           congratsPage.setRedirect(true);
           congratsPage.getParameters().put('id',controller.getId());
           return congratsPage;
          }return null;
Catch(Exception e){
   ApexPages.Message myMsg = new ApexPages.Message(ApexPages.Severity.ERROR, e.getMessage());
   ApexPages.addMessages(myMsg);
   return null;
}