SAVE BUTTON :Selected Cases does not get closed on Save Button ,it Closes all the cases

Question

Can any one help me out on this?

I have a created a vf page ,i have been using the standard button functionality SAVE and CANCEL .But the problem is the Save button does not work as per the requirement.when i select few cases for Mass Closer of cases ,i give the data as "Status=closed" click on save it should save the data ,but what happens here is Instead of closing the selected cases,it Closes all the records which are not selected .

For Example : I have few cases number as 471771 ,72 ,73 ,74 ,75 .Now i will select 71 ,72,73 cases for Mass closing and once i select the Mass close button and give the case status as "closed" and update the comments.click on the save button.The save button functionality should save the selected cases and update it.What happens is the selected cases as well as the non selected cases get closed.

VF Page :

<apex:page controller="MassCloseCasesController" sidebar="false"> 
  <apex:form > 
    <apex:SectionHeader title="Close Cases"/> 
      <apex:pageBlock > 
        <apex:pageBlockButtons location="Both"> 
          <apex:commandButton action="{!Save}" value="Save"/> 
          <apex:commandButton action="{!Cancel}" value="Cancel" immediate="true"/> 
        </apex:pageBlockButtons> 
           <apex:pageBlockSection collapsible="false" title="Case Information" > 
             <apex:inputField value="{!objCase.Status}"/> 
             <apex:inputField value="{!objCase.Reason_For_Resolution__c}" label="Reason For Resolution"/> 
             <apex:inputField value="{!objCase.Comment__c}" label="Internal Comments"/> 
             <apex:inputField value="{!objCase.Do_Not_Send_Email_Case_Closure__c}" label="Do Not Send Email Case Closure"/> 
          </apex:pageBlockSection> 
       </apex:pageBlock> 
   </apex:form> 
</apex:page>

Code :

public with sharing class MassCloseCasesController { 

      public Case objCase {get;set;} 
      private List<Case> lstCase; 
      public MassCloseCasesController() 
                            { 
                               objCase = new Case(); 
                               lstCase = new List<Case>(); 
                               lstCase = [SELECT Id, Status, Reason_For_Resolution__c, Comment__c, Do_Not_Send_Email_Case_Closure__c FROM Case]; 
                            } 
     public PageReference save() 
                           { 
                              for(Case objCaseRecord: lstCase) 
                            { 
                              objCaseRecord.Status = objCase.Status; 
                              objCaseRecord.Reason_For_Resolution__c = objCase.Reason_For_Resolution__c; 
                              objCaseRecord.Comment__c = objCase.Comment__c; 
                              objCaseRecord.Do_Not_Send_Email_Case_Closure__c = objCase.Do_Not_Send_Email_Case_Closure__c; 
                            } 
                              update lstCase; 
                              return new pagereference('/500'); 

                           } 
     public PageReference cancel() 
                            { 
                              return new pagereference('/500'); 
                          } 
}

Any help very much appreciated.

Answer 1

That is because you have following query in your constructor

lstCase = [SELECT Id, Status, Reason_For_Resolution__c,
 Comment__c, Do_Not_Send_Email_Case_Closure__c FROM Case];

which select all the cases regardless what you select from list view.

You need to pass the selected items only in your constructor.

your code should be updated in following ways

Visualforce page

<apex:page standardcontroller="case" extensions="MassCloseCasesController" sidebar="false" recordSetVar="cases"> 
  <apex:form > 
    <apex:SectionHeader title="Close Cases"/> 
      <apex:pageBlock > 
        <apex:pageBlockButtons location="Both"> 
          <apex:commandButton action="{!caseSave}" value="Save"/> 
          <apex:commandButton action="{!Cancel}" value="Cancel" immediate="true"/> 
        </apex:pageBlockButtons> 
           <apex:pageBlockSection collapsible="false" title="Case Information" > 
             <apex:inputField value="{!objCase.Status}"/> 
             <apex:inputField value="{!objCase.Reason_For_Resolution__c}" label="Reason For Resolution"/> 
             <apex:inputField value="{!objCase.Comment__c}" label="Internal Comments"/> 
             <apex:inputField value="{!objCase.Do_Not_Send_Email_Case_Closure__c}" label="Do Not Send Email Case Closure"/> 
          </apex:pageBlockSection> 
       </apex:pageBlock> 
   </apex:form> 
</apex:page>

Apex Class:

public with sharing class MassCloseCasesController { 

      public Case objCase {get;set;} 
      private List<Case> lstCase{get;set;} 
      public MassCloseCasesController(ApexPages.StandardSetController standardController) 
                            { 
                               objCase = new Case(); 
                               lstCase = new List<Case>(); 
                               lstCase = (List<Case>) standardController.getSelected();


     } 
     public PageReference casesave() 
                           { 
                              for(Case objCaseRecord: lstCase) 
                            { 
                              objCaseRecord.Status = objCase.Status; 
                              objCaseRecord.Reason_For_Resolution__c = objCase.Reason_For_Resolution__c; 
                              objCaseRecord.Comment__c = objCase.Comment__c; 
                              objCaseRecord.Do_Not_Send_Email_Case_Closure__c = objCase.Do_Not_Send_Email_Case_Closure__c; 
                            } 
                              update lstCase; 
                              return new pagereference('/500'); 

                           } 
     public PageReference cancel() 
                            { 
                              return new pagereference('/500'); 
                          } 
}

Answer 2

Here is something you can do:

Change your Close(list view button) to execute OnClick Javascript and write this code asthe javascript.

var ids= {!GETRECORDIDS($ObjectType.Case)}; 
if(ids.length < 1 ) 
 alert('Please select at least one case.'); 
else 
 window.open('/apex/YourPageName?ids='+ids.join(',')); //Replace YourPageName with your VF page name

Then in your VF page controller, change the code to this.

public with sharing class MassCloseCasesController { 

      public Case objCase {get;set;} 
      private List<Case> lstCase; 
      public List<string> caseIDS(get;set;}
      public MassCloseCasesController() 
                            { 
                               objCase = new Case(); 
                               lstCase = new List<Case>(); 
                               lstCase = [SELECT Id, Status, Reason_For_Resolution__c, Comment__c, Do_Not_Send_Email_Case_Closure__c FROM Case]; 
String ids = ApexPages.currentPage().getParameters().get('ids');
if(ids != null)
{
 caseIDS = ids.split(',');
 lstCase = [SELECT Id, Status, Reason_For_Resolution__c, Comment__c, Do_Not_Send_Email_Case_Closure__c FROM Case where Id IN :caseIDS]; 
}
                            } 
     public PageReference save() 
                           { 
                              for(Case objCaseRecord: lstCase) 
                            { 
                              objCaseRecord.Status = objCase.Status; 
                              objCaseRecord.Reason_For_Resolution__c = objCase.Reason_For_Resolution__c; 
                              objCaseRecord.Comment__c = objCase.Comment__c; 
                              objCaseRecord.Do_Not_Send_Email_Case_Closure__c = objCase.Do_Not_Send_Email_Case_Closure__c; 
                            } 
                              update lstCase; 
                              return new pagereference('/500'); 

                           } 
     public PageReference cancel() 
                            { 
                              return new pagereference('/500'); 
                          } 
}