Best optimized way to get logged in user info and set variables in apex controller

Question

I want to know the best optimized way to access current logged in user's information and set few flags. I have a controller extension and I have set flags in constructor like this:

User u = [SELECT ID,Name,ProfileID,Profile.Name,UserRole.Name,UserRole.ID,Team_Lead__c,Leading_Teams__c,Department,Desk__c
             FROM User 
             WHERE id=:userId];

if(u.UserRole.Name != null && u.UserRole.Name.contains('xyz')){
                isComUser = true;
      }      
            if(u.UserRole.Name != null && u.UserRole.Name.contains('pqr'))   { 
                isFPUser = true; 
}

...and the conditions go on.. There are so many conditions that constructor has become really big & unmanagable.

Is there a good way to do this? Thanks in advance

Answer 1

You can use conditions as Boolean assignments to reduce the complexity of the code. This has the side effect of increasing code coverage "for free", as you no longer have to test each IF statement solely for the purpose of code coverage. You can also combine this with getters for even more compactness. For example:

public Boolean isComUser { get { return u.UserRole.Name != null && u.UserRole.Name.contains('xyz'); } }

(Assume that u is instead defined as a global variable instead of inside a function).

Even just placing this technique in your constructor can reduce complexity:

isComUser = u.UserRole.Name != null && u.UserRole.Name.contains('xyz');

This will also ensure that all variables are initialized to true/false, avoiding System.NullPointerException errors when using the values.

Finally, I also tend to leverage Custom Permissions to assign permissions to profiles, or Custom Settings to avoid wasting SOQL queries. It's generally a better idea to create permissions or settings instead of hard-coding data into the user's profile or role name.