Apex method not changing record type of an object

Question

So Im making an Apex class that I want to push to production that will change the record type of an object, to a different record type.

Here is the class below:

public class removeclassy {
List<Campaign> camplist = [SELECT Name,id FROM Campaign WHERE RecordTypeid = '01215000001YqO9AAK'];
 public void DestroyCampClassy()
    {
        for(Campaign camp : camplist)
    {
        camp.RecordTypeId ='01215000001DWqoAAG';
        if(camp.RecordTypeId == '01215000001DWqoAAG')
        {
            System.debug('record type changed on this record: '+ camp.Name);
            update camp;
        }
    }
        System.debug('Loop finished');
    }
}

And here is the Test method that i want to pair with it.

@IsTest static void testCamp()
    {
        Campaign camp = new Campaign();
        camp.Name = 'test';
        camp.RecordTypeId = '01215000001YqO9AAK';
        Test.startTest();
        insert camp;
        Test.stopTest();
        removeclassy rem = new removeclassy();
        rem.DestroyCampClassy();
        system.assertEquals('01215000001DWqoAAG', camp.RecordTypeId);
        
    }

The problem that I am encountering is that the test object that I create doesn't get its record type changed when I call the class. The class itself does an SOQL query that should get all the objects with that objects specific record type in order to change it to another. But for some reason the DestroyCampClassy method does not change this. Any thoughts?

Answer 1

As I explain in depth in this answer, the state of the record in memory has nothing to do with the state of the record in the database. When you perform an operation in a trigger, and you're testing this in your class, you need to remember to query the records back afterwards to check for changes.

    Campaign camp = new Campaign();
    camp.Name = 'test';
    camp.RecordTypeId = '01215000001YqO9AAK';
    Test.startTest();
    insert camp;
    Test.stopTest();
    removeclassy rem = new removeclassy();
    rem.DestroyCampClassy();
    camp = [SELECT RecordTypeId FROM Campaign WHERE Id = :camp.Id];
    system.assertEquals('01215000001DWqoAAG', camp.RecordTypeId);
    

P.S. You should use the DescribeSObjectResult class to get the Record Type Id dynamically by name instead of hard-coding ID values. This will cause you trouble in the future.