FieldSet is not working

Question

I am trying to learn FieldSet from this Salesforce document but i am getting the following Error while saving this class

public class MerchandiseDetails {

public Merchandise__c merch { get; set; }

public MerchandiseDetails() {
    this.merch = getMerchandise();
}

public List<Schema.FieldSetMember> getFields() {
    return SObjectType.Merchandise__c.FieldSets.Dimensions.getFields();
}

private Merchandise__c getMerchandise() {
    String query = 'SELECT ';
    for(Schema.FieldSetMember f : this.getFields()) {
        query += f.getFieldPath() + ', ';
    }
    query += 'Id, Name FROM Merchandise__c LIMIT 1';
    return Database.query(query);
}}

Error: MerchandiseDetails Compile Error: dimensions is not a fieldSet of Merchandise__c at line 10 column 16

should i need do extra settings to enable FieldSet?

Thanks

Answer 1

https://ap1.salesforce.com/help/doc/en/fields_editing_field_sets.htm

For your Merchandise_c Object you will need to configure your fieldset.The above example in salesforce guide assumes you already have a fieldset named Dimensions for your Merchandise_c Object.

refre the above link on how to create fieldsets in salesforce for an object and make sure you refer same name as you assign in fieldset in your apex code .

Answer 2

You have not added dimensions field set on your Merchandise__c object. Create dimensions field set and your problem will be resolved.

And second thing in your getMerchandise() method you have hard coded Id and name fields, it should not be there. If someone comes and add ID or name field explicitly in your field set in that case in your query there would be 2 ID or name fields and your code will fail.

so the code should be like this -

private Merchandise__c getMerchandise() {
    String query = 'SELECT ';
    integer i = 0;
    for(Schema.FieldSetMember f : this.getFields()) {
         if (i == 0) {
            query += f.getFieldPath();  
          }
          else {
            query +=  ', ' + f.getFieldPath(); 
          }
            i++;
     }       
    query += ' FROM Merchandise__c LIMIT 1';
    return Database.query(query);
}