NullPointer exception while accessing compound field Address

Question

I'm working on trigger that will [after insert] get Street from ContactPointAddress object connected via lookup (Contact__c) and re-write MailingStreet field in Contact object ONLY if checkbox isDefault is checked. This is what I've done so far:

public static void AfterInsert(ContactPointAddress[] lstContactPointAddresses)
        {
            List<Contact> allPassagersToBeUpdated= new List<Contact>();
            for (ContactPointAddress tmpContactPointAddress : lstContactPointAddresses)
                {
                    // created contactPointAddress is checked - is default
                    if (tmpContactPointAddress.IsDefault == true) {
                        Contact passenger = [SELECT Name,LastName,MailingStreet FROM Contact WHERE Id =: tmpContactPointAddress.Contact__c];

                        Address addressCompoundField = (Address)tmpContactPointAddress.Address;
                        passenger.MailingStreet = addressCompoundField.Street;
                        allPassagersToBeUpdated.add(passenger);

                    }
                    else {
                        return;
                    }

                }
            if(allPassagersToBeUpdated.size()>0){
                update allPassagersToBeUpdated;
            }

        } 

The problem is, my compound field Addres in Contact Point Address is always null. I don't know why as I can acces values of other fields. Can anyone help me please? Thanks a lot:)

p.s: my exact error is:

Trg_ContactPointAddress: execution of AfterInsert caused by: System.NullPointerException: Attempt to de-reference a null object Class.Trg_ContactPointAddress_Handler.AfterInsert: line 31, column 1 Trigger.Trg_ContactPointAddress: line 14, column 1

---

I tried to re-arrange the code in order to save SOQL calls to database and end up with sth like this:

    public static void AfterInsert(ContactPointAddress[] lstContactPointAddresses) {

        List<Contact> allPassengersToBeUpdated = new List<Contact>();
        set<Id> setOfPassengersIds = new set<Id>();

        for (ContactPointAddress tmpContactPointAddress : lstContactPointAddresses) {
            // created contactPointAddress is checked - is default
            if (tmpContactPointAddress.IsDefault == true) {
                setOfPassengersIds.add(tmpContactPointAddress.Contact__c);
            } else {
                return;
            }
        }

        map<Id, Contact> mapPassengers = new map<Id, Contact>([SELECT Id, MailingStreet FROM Contact WHERE Id IN :setOfPassengersIds ]);
        map<Id, ContactPointAddress> mapCPA = new map<Id, ContactPointAddress>([SELECT Id, Address FROM ContactPointAddress WHERE Id IN :lstContactPointAddresses ]);

        for(Contact passenger: mapPassengers.values()) {
            passenger.MailingStreet = ((Address)mapCPA.get(passenger.Id).Address).Street;
            allPassengersToBeUpdated.add(passenger);
        }


        if (allPassengersToBeUpdated.size() > 0) {
            update allPassengersToBeUpdated;
        }
    }

But still getting the same error

Answer 1

In order to use the Address class you'll need to query for the compound address field. In your case that will be MailingAddress. MailingStreet is only a part of the whole.

You will also need to use the getStreet() method on the Address object.

public static void AfterInsert(ContactPointAddress[] lstContactPointAddresses) {
    List<Contact> allPassagersToBeUpdated = new List<Contact>();
    for (ContactPointAddress tmpContactPointAddress : lstContactPointAddresses) {
        // created contactPointAddress is checked - is default
        if (tmpContactPointAddress.IsDefault) {
            Contact passenger = [
                SELECT Name
                        ,LastName
                        ,MailingAddress 
                FROM Contact 
                WHERE Id = :tmpContactPointAddress.Contact__c
            ];
            Address addressCompoundField = (Address)tmpContactPointAddress.MailingAddress;
            passenger.MailingStreet = addressCompoundField.getStreet();
            allPassagersToBeUpdated.add(passenger);
        } else {
            return;
        }
    }

    if(allPassagersToBeUpdated.size() > 0) {
        update allPassagersToBeUpdated;
    }

• Reference for the Contact standard fields.
• Reference for the Address class

Additionally, it's a bad practice to make SOQL queries inside of a for-loop, especially when it looks like the code is called from a trigger. You will want to bulkify your code so that you query for all of your addresses at once. There are a number of good resources for this here and elsewhere.

Answer 2

I see that you're trying to set the Contact's MailingStreet to the Street in the ContactPointAddress object that is related to the Contact. You can try the following codes:

public static void AfterInsert(ContactPointAddress[] lstContactPointAddresses) {

    List<Contact> allPassengersToBeUpdated = new List<Contact>();
    map<Id, String> mapCPA = new map<Id, String>();

    for (ContactPointAddress tmpContactPointAddress : lstContactPointAddresses) {
        // created contactPointAddress is checked - is default
        if (tmpContactPointAddress.IsDefault == true) {
            setOfPassengersIds.put(tmpContactPointAddress.Contact__c, tmpContactPointAddress.Street);
        } else {
            return;
        }
    }

    if (!mapCPA.isEmpty()) {
        map<Id, Contact> mapPassengers = new map<Id, Contact>([SELECT Id, MailingStreet FROM Contact WHERE Id IN :mapCPA.keyset()]);
    
        for(Contact passenger: mapPassengers.values()) {
            passenger.MailingStreet = mapCPA.get(passenger.Id);
            allPassengersToBeUpdated.add(passenger);
        }

        if (allPassengersToBeUpdated.size() > 0) {
            update allPassengersToBeUpdated;
        }
    }
}