Salesforce Selector layer - subquery

Question

We have been using FF library for Separation of Concerns framework and it is working great. We need to add subquery to it, but running into issues. Example I am following is from this article: https://quirkyapex.com/2016/08/18/fflib-selector-layer/

public class OpportunityLineItemsSelector extends fflib_SObjectSelector {

   public Schema.SObjectType getSObjectType(){
      return OpportunityLineItem.sObjectType;
   }

   public override List<Schema.SObjectField> getSObjectFieldList(){
      return new List<Schema.SObjectField> {
         OpportunityLineItem.Id,
         OpportunityLineItem.Quantity,
         OpportunityLineItem.SalesPrice
      };
   }

}

public class OpportunitiesSelector extends fflib_SObjectSelector {

   public Schema.SObjectType getSObjectType(){
      return Opportunity.sObjectType;
   }

   public override List<Schema.SObjectField> getSObjectFieldList(){
      return new List<Schema.SObjectField> {
         Opportunity.Id,
         Opportunity.StageName
      };
   }

   public List<Opportunity> selectByIdWithLineItems(Set<Id> recordIds){
      fflib_QueryFactory query = newQueryFactory();
      query.setCondition('Id IN :recordIds');
      query.addQueryFactorySubselect( 
         new OpportunityLineItemsSelector().newQueryFactory() 
      );
      return (List<Opportunity>) Database.query( query.toSOQL() );
   }

}

I get compile error:

Method does not exist or incorrect signature: void addQueryFactorySubselect(fflib_QueryFactory) from the type fflib_QueryFactory at line 17 column 13

Below method does exist in "fflib_SObjectSelector" class

global fflib_QueryFactory addQueryFactorySubselect(fflib_QueryFactory parentQueryFactory)
{
    return addQueryFactorySubselect(parentQueryFactory, true);
}

What am I missing here?

Answer 1

Your method

public List<Opportunity> selectByIdWithLineItems(Set<Id> recordIds){
      fflib_QueryFactory query = newQueryFactory();
      query.setCondition('Id IN :recordIds');
      query.addQueryFactorySubselect( 
         new OpportunityLineItemsSelector().newQueryFactory() 
      );
      return (List<Opportunity>) Database.query( query.toSOQL() );
   }

Option 1: should look like this to include subqueries (gives you option to decide on subquery fields)

public List<Opportunity> selectByIdWithLineItems(Set<Id> recordIds){
      if (recordIds.isEmpty()) return new list<Opportunity>(); // avoid burning SOQL
      fflib_QueryFactory oQf = newQueryFactory()
                                .setCondition('Id IN :recordIds');

      fflib_QueryFactory oliQueryFactory = oQF.subselectQuery('OpportunityLineItems')
                .selectFields(new OpportunityLineItemsSelector().getSobjectFieldList()); 

      return Database.query(oQf.toSOQL() );
   }

Option 2: or should should look like this (see example in fflib github) - unconditionally get all subquery fields

public List<Opportunity> selectByIdWithLineItems(Set<Id> recordIds){
      if (recordIds.isEmpty()) return new list<Opportunity>(); // avoid burning SOQL
      fflib_QueryFactory oQF = newQueryFactory()
                                .setCondition('Id IN :recordIds');

      fflib_QueryFactory oliQF = new OpportunityLineItemsSelector().
            addQueryFactorySubselect(oQF,'OpportunityLineItems');

      return Database.query(oQF.toSOQL() );
   }