System.QueryException: expecting a colon, found 'setids'

Question

I keep getting the error:

System.QueryException: expecting a colon, found 'setids'

Why do I get this error? How can I fix it?

public Database.QueryLocator start(Database.BatchableContext context) {
    Set<Id> setids = new Set<Id>();
    for(Task t : [SELECT WhatId FROM Task WHERE Is_Precall__c = true AND Is_Created_By_Batch__c = true AND CreatedDate = TODAY]){
        setids.add(t.WhatId);
    } 


    String q = 'SELECT Id, Route_Lookup__c, Next_Delivery_Date__c,';
         q += ' Market_Center_Lookup__c,';
         q += ' (SELECT Id FROM Orders__r WHERE Status = \'Pending\')';
         q += ' FROM ServicePoint__c WHERE Type__c = \'Active\'';
         q += ' AND Is_Batch_Exec_Date__c = true';
         q += ' AND Is_Precall_Customer__c = true';
         q += ' AND Id NOT IN setids' ;
    return Database.getQueryLocator(q);
}

Answer 1

When you reference an apex variable in a query (standard, or dynamic as is your case), you need to prefix the variable name with a colon :. This is called expression binding. You can still use expression binding in dynamic soql. Though there are some additional considerations when using this with dynamic soql, I don't believe any of them apply in this particular case.

The line in question here is

q += ' AND Id NOT IN setids' ;

and the correct way to do this would be

// Notice the colon (:) added before setids
q += ' AND Id NOT IN :setids';

Answer 2

Your passing set variable setids to an queryLocator on this line ,

q += ' AND Id NOT IN setids' ;

make correction on that line

q += ' AND Id NOT IN : setids' ; //add : before setids