Onclick Javascript Issue

Question

{!REQUIRESCRIPT("/soap/ajax/33.0/connection.js")} 
{!REQUIRESCRIPT("/soap/ajax/33.0/apex.js")} 

var rcn = "{!Opportunity.Description__c}"; 
var amt = "{!Opportunity.Amount}"; 
if( rcn!= '' && amt!= '' && amt!= '0.00') 
{ 
window.open("{!URLFOR( $Action.Opportunity.Submit, Opportunity.Id )}"); 
} 
else if (amt=='' || amt =='0.00') 
{ 
alert("Enter Amount"); 
} 
else if (rcn=='') 
{ 
alert("Enter Description"); 
} 
else 
{ 
alert("Enter Amount and Description"); 
}

Here my target is that I should be able to submit an opportunity for approval only if Amount and Description are entered. Else it should throw errors separately is any of those fields is null/zero. This code is alowing me to submit even though Amount is null and also Description is null.

Answer 1

Lots of minor issues. Let's fix it up:

{!REQUIRESCRIPT("/soap/ajax/33.0/connection.js")}
{!REQUIRESCRIPT("/soap/ajax/33.0/apex.js")} 

Not required here. Remove these lines, as they're just causing additional loading time.

var rcn = "{!JSENCODE(Opportunity.Description__c)}"; 

Make sure you encode text values.

var amt = {!BLANKVALUE(Opportunity.Amount, 0)}; 

Use a real number, it's easier.

if(rcn && amt) {

Nulls, undefined values, empty strings and 0 is a "falsy" value, anything else is "truthy" value.

    window.open("{!JSENCODE(URLFOR( $Action.Opportunity.Submit, Opportunity.Id ))}"); 

Again, just a good habit, even though this is most likely safe.

} else if(!amt && !rcn) {
    alert("Enter Amount and Description"); 
} else if(!amt) {
    alert("Enter Amount"); 
} else {
    alert("Enter Description"); 
}

You have to check the most specific situations first. In the original code, !amt && !rcn could never be reached, because the less specific conditions would be met first.

---

Final version:

var rcn = "{!JSENCODE(Opportunity.Description__c)}"; 
var amt = {!BLANKVALUE(Opportunity.Amount, 0)}; 
if(rcn && amt) {
    window.open("{!JSENCODE(URLFOR( $Action.Opportunity.Submit, Opportunity.Id ))}"); 
} else if(!amt && !rcn) {
    alert("Enter Amount and Description"); 
} else if(!amt) {
    alert("Enter Amount"); 
} else {
    alert("Enter Description"); 
}