Apex Test Class Code Coverage Failure

Question

This is the Trigger that I am trying to get code coverage for, but my test class is failing.Both testMethods are passing, but it's saying "No Code Coverage". So I guess my two test methods aren't really testing anything? Can someone help explain where I am going wrong, or what I am missing? Thanks!

Trigger

    trigger FinanceApprovalAdDirector on Rate_Request__c (before insert,before update) {
    for(Rate_Request__c fa: trigger.new)
    {
        Market__c m = [Select Ad_Director__c From Market__c WHERE Unit_Number__c = :fa.Owner_Market__c];
        fa.Ad_Director__c = m.Ad_Director__c;
        User u = [Select ManagerId From User WHERE Id = :UserInfo.getUserId()];
        fa.Manager__c = u.ManagerId;
    }
}

My Test Class

@isTest(SeeAllData=true)
public class FinanceApprovalAdDirectorTest{
 static testMethod void testRateRequestManager(){
        Profile p = [SELECT Id FROM Profile WHERE Name='Standard User'];
        User u1 = new User(Alias = 'standt1', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]');      
        User u = new User(Alias = 'standt', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]', ManagerId = u1.id);      

        System.runAs(u){
            Market__c m = new Market__c();
            m.Unit_Number__c = '1111';
            m.Name = 'test';
            m.Ad_Director__c = u.id;
            insert m;

            Market__c mTest = [SELECT Ad_Director__c, Unit_Number__c, Name FROM Market__c WHERE Unit_Number__c = :m.Unit_Number__c];

            test.startTest();
            Rate_Request__c rr = new Rate_Request__c();
            rr.Ad_Director__c = mTest.Ad_Director__c;
            rr.Manager__c = u.ManagerId;

            System.assertEquals(u1.id, rr.Manager__c);
            System.assertNotEquals(u.id, rr.Manager__c);
            test.stopTest();
        }
    }

    static testMethod void testRateRequestAdDirector(){
        Profile p = [SELECT Id FROM Profile WHERE Name='Standard User'];
        User u = new User(Alias = 'standt1', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]');      
        User u1 = new User(Alias = 'standt', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]', ManagerId = u.id);      

        System.runAs(u){
            Market__c m = new Market__c();
            m.Unit_Number__c = '1111';
            m.Name = 'test';
            m.Ad_Director__c = u.id;
            insert m;

            Market__c mTest = [SELECT Ad_Director__c, Unit_Number__c, Name FROM Market__c WHERE Unit_Number__c = :m.Unit_Number__c];

            test.startTest();
            Rate_Request__c rr = new Rate_Request__c();
            rr.Ad_Director__c = mTest.Ad_Director__c;

            System.assertEquals(u.id, rr.Ad_Director__c);
            System.assertNotEquals(u1.id, rr.Ad_Director__c);
            test.stopTest();
        }     
    }    

}

Answer 1

First Mistake:

You should never have a SOQL query inside for loop.

Before moving to your test classes, replace your code with this

Map<ID,List<String>> markerOwnerList = new Map<ID,List<String>>();
for(Rate_Request__c fa: trigger.new){
    if(markerOwnerList.containsKey(fa.Owner_Market__c))
        markerOwnerList.get(fa.Owner_Market__c).add(fa.id);
    else
        markerOwnerList.put(fa.Owner_Market__c,new List<String>{fa.id});
}

Map<ID,String> rrDirectorMap = new Map<ID,String>();

for(Market__c m : [Select Ad_Director__c,Unit_Number__c From Market__c WHERE Unit_Number__c = :markerOwnerList.keySet()]){
    for(String rateRequest : markerOwnerList.get(m.Unit_Number__c))
        rrDirectorMap.put(rateRequest,m.Ad_Director__c);
}

User u = [Select ManagerId From User WHERE Id = :UserInfo.getUserId()];
for(Rate_Request__c fa: trigger.new){
    if(rrDirectorMap.containsKey(fa.id))
        fa.Ad_Director__c = rrDirectorMap.get(fa.id);

    fa.Manager__c = u.ManagerId;
}

Regarding your test class, you are not inserting the RateRequest record after creating it.

@isTest(SeeAllData=true)
public class FinanceApprovalAdDirectorTest{
 static testMethod void testRateRequestManager(){
        Profile p = [SELECT Id FROM Profile WHERE Name='Standard User'];
        User u1 = new User(Alias = 'standt1', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]');      
        User u = new User(Alias = 'standt', Email='[email protected]', EmailEncodingKey='UTF-8', LastName='Testing', LanguageLocaleKey='en_US', LocaleSidKey='en_US', ProfileId = p.Id, TimeZoneSidKey='America/Los_Angeles', UserName='[email protected]', ManagerId = u1.id);      

        System.runAs(u){
            Market__c m = new Market__c();
            m.Unit_Number__c = '1111';
            m.Name = 'test';
            m.Ad_Director__c = u.id;
            insert m;

            Market__c mTest = [SELECT Ad_Director__c, Unit_Number__c, Name FROM Market__c WHERE Unit_Number__c = :m.Unit_Number__c];

            test.startTest();

            Rate_Request__c rr = new Rate_Request__c();
            insert rr;

            System.assertEquals(u1.id, rr.Manager__c);
            System.assertNotEquals(u.id, rr.Manager__c);
            test.stopTest();
        }
    }
}

I hope you will be able to fix your next method.

Answer 2

First Issue:

You are not Inserting the Rate_Request__c records so the trigger will never execute.

trigger FinanceApprovalAdDirector on Rate_Request__c (before insert,before update) 

Since the trigger happens on insert or update it will not run unless you insert or update the appropriate records.

Once you do that this will happen

Your query:

[Select Ad_Director__c From Market__c WHERE Unit_Number__c = :fa.Owner_Market__c];
        fa.Ad_Director__c = m.Ad_Director__c;

requires that the Rate_Request__c.Owner_Market__c match the Unit_Number__c.

I do not see in your tests where you are setting the value of the Rate_Request__c.Owner_Market__c` thus it is null and does not match the value or the Unit_number__c and thus will return no results

This will result in a List has no rows for assignment to sObject error