Trying to get Code Coverage on my apex Class

Question

I'm trying to get code coverage on my class to no avail. Any assistance would be greatly appreciated. I'm sure there is a better way to write my class but just trying to get the end user his request at this point. I've spent a couple of days fiddling with this and tried Googling many resources.

Here is my Class

global with sharing class BusinessIntelligenceFeedback {

  public String BusIntId{get;set;}

  public Business_Intelligence_Survey__c bif {
    get {
      if (bif == null)
        bif = new Business_Intelligence_Survey__c(
        Business_Intelligence__c = BusIntId,
        Survey_Results__c = 'Yes'
        );
      return bif;
    }
    set;
  }

  // save button is clicked
 public PageReference save() {

    try {
      insert bif; // inserts the new record into the database
    } catch (DMLException e) {
      ApexPages.addMessage(new ApexPages.message(ApexPages.severity.ERROR,'Error creating new bif.'));
      return null;
    }
        // if successfully inserted new BISurvey, then displays the thank you page.
    return Page.BusinessIntelligence_Create_Thankyou;
  }

}

Here is my Test Class

@isTest(SeeAllData=true)

private class TestBusinessIntelligenceFeedback {
    static testMethod void testMe(){

  Business_Intelligence_Survey__c bif = new Business_Intelligence_Survey__c();
        bif.Business_Intelligence__c = 'a24U00000005kkL';
        bif.Survey_Results__c = 'Yes';
        insert bif;

    Business_Intelligence_Survey__c testbif = [select Id, Survey_Results__c, name from Business_Intelligence_Survey__c where id =:bif.Id]; 

     System.debug('Status on ticket after trigger fired: ' + bif.Survey_Results__c);

       // Test that the trigger correctly updated the survey

       System.assertEquals('Yes', bif.Survey_Results__c);

    }

}

Answer 1

Your unit test appears to be the standard form for testing a trigger. You're not trying to test a trigger, so this type of pattern is inappropriate. Instead, you want to use a "test a class" form. Here's the minimum changes you'd want to make:

@isTest(SeeAllData=true)

private class TestBusinessIntelligenceFeedback {
    static testMethod void testMe(){
        BusinessIntelligenceFeedback controller = new BusinessIntelligenceFeedback();
        controller.BusIntId = 'a24U00000005kkL';
        controller.save();
        System.assertNotEquals(null, controller.bif.Id);
    }
}

As others have commented, you should be creating all records you need within the unit test, instead of hard-coding an Id in your code. This can cause unexpected changes in behavior when migrating between environments or if someone modifies/deletes the record referenced by the hard-coded Id.

That might look like:

@isTest

private class TestBusinessIntelligenceFeedback {
    static testMethod void testMe(){
        Business_Intelligence__c bi = new Business_Intelligence__c();
        // populate required fields here, then insert
        insert bi;
        BusinessIntelligenceFeedback controller = new BusinessIntelligenceFeedback();
        controller.BusIntId = bi.Id;
        controller.save();
        System.assertNotEquals(null, controller.bif.Id);
    }
}

Answer 2

Just a note on how to cover the catch block, my standard approach is to use a lookup Id for the incorrect sObjectType. For example, if you set busIntId to a User Id, then you should get a DmlException.

static testMethod void testSave()
{
    MyController controller = new MyController();
    controller.busIntId = UserInfo.getUserId();

    Test.startTest();
        controller.save();
    Test.stopTest();

    system.assert(ApexPages.hasMessages(), '<assertion message here>');
}

Answer 3

I did some modification to your code, check if this helps you to with your coverage. I pefer not to set see all data true.

   @isTest(SeeAllData=true)
    private class TestBusinessIntelligenceFeedback {
        static testMethod void testMe(){

            BusinessIntelligenceFeedback bIfController = new BusinessIntelligenceFeedback();

            Test.startTest();
            bIfController.BusIntId = 'a24U00000005kkL';
            bIfController.bif = BusinessIntelligenceFeedback.bif;
            bIfController.save();
            Test.stopTest();

            Business_Intelligence_Survey__c testbif = [select Id, Survey_Results__c, name from Business_Intelligence_Survey__c where id =:bif.Id]; 

            System.debug('Status on ticket after trigger fired: ' + bIfController.Survey_Results__c);

            // Test that the trigger correctly updated the survey

            System.assertEquals('Yes', bif.Survey_Results__c);

        }

    }