Help with Basic Trigger

Question

Could you help me find the problem with my custom Trigger? In a nutshell, I would like a picklist field called “Housekeeping_Status__c” to be updated to ‘Clean’ when the Account Id on one object (Housekeeping__c), is the exact account Id on another object (Property_Rate__c). Each object is unrelated but both share the same parent Account. This trigger should run (after insert, after update).

I should also mention that I have a second Housekeeping__c trigger (“Before insert, before update”) which populates the Account__r.Id on the Housekeeping__c record. I have no problem with this trigger.

Here is the broken code:

trigger setToClean on Housekeeping__c (after insert, after update)
{

     for (Housekeeping__c housekeeping : Trigger.new)
     {
           String houseaccount = housekeeping.Account__r.Id;

           List<Property_Rate__c> findRates = [SELECT Id FROM Property_Rate__c WHERE Account__r.Id = :houseaccount];

           for (Property_Rate__c currentRate : findRates)
           {
               currentRate.Housekeeping_Status__c = ‘Cleaned';
           }

     }
}

Answer 1

UPDATE : Applied @snehakem suggestion

You are assigning the new value for the field but not updating the records. Just perform required DML.

trigger setToClean on Housekeeping__c (after insert, after update)
{
    List<Property_Rate__c> updatedPropertyList = new List<Property_Rate__c>();
    Set<String> accountIds = new Set<String>();

    for(Housekeeping__c housekeeping : Trigger.new){
        accountIds.add(housekeeping.Account__c);
    }

    List<Property_Rate__c> findRates = [SELECT Id, Housekeeping_Status__c FROM Property_Rate__c WHERE Account__r.Id IN :accountIds];

    for (Property_Rate__c currentRate : findRates)
    {
       currentRate.Housekeeping_Status__c = 'Cleaned';
       updatedPropertyList.add(currentRate);
    }

    update updatedPropertyList;  // This is what you are missing     
}

NOTE: This suggestion(not compiled and tested) is just for resolving your field not updating issue. Addition to that have a look at for the code if it's satisfying your requirement (I feel like you need some conditional statement).
Also note that it's not a good idea to have multiple triggers on same object as in documentations.

Answer 2

Try this,

trigger setToClean on Housekeeping__c (after insert, after update)

    List<Property_Rate__c> listToBeUpdated = new List<Property_Rate__c>();
        Set<Id> setAccId = new Set<Id>();

         for (Housekeeping__c housekeeping : Trigger.new)
         {
            setAccId.add(housekeeping.Account__c);
         }

         Map<Id,Property_Rate__c> mapAccIdProperty = new ap<Id,Property_Rate__c>();//Query outside for loop

         for(Property_Rate__c p :[SELECT Id,Account__c FROM Property_Rate__c WHERE Account__c = :setAccId]){
            mapAccIdProperty.put(p.Account__c,p);
         }
         for (Housekeeping__c housekeeping : Trigger.new)
         {
           if(housekeeping.Account__c!=null && mapAccIdProperty.keyset().contains(housekeeping.Account__c)){
                mapAccIdProperty.get(housekeeping.Account__c).Housekeeping_Status__c = ‘Cleaned';
                listToBeUpdated.add(mapAccIdProperty.get(housekeeping.Account__c));
           }   

         }
     if(listToBeUpdated.size()>0){
        update listToBeUpdated;    
     }
    }