Keep getting Issues on handling multiple records-List index out of bounds: 0

Question

I'm trying to modify my code which works for single account, but I need to handle multiple accounts.

split[0] : holds the account name
split[1] : holds the email

This is my code:

list<string> slistAcc = new list<string>{'[email protected]','[email protected]'};
system.debug(slistAcc);

list<account> acct = new list<account>();
list<account> p2 = new list<account>();

string[] b;

for(integer i=0;i<slistAcc.size();i++) 
{


    string a = slistAcc[i];
      b = a.split('_');

    system.debug('b --->' + b); << ---DEBUG|b --->(abc, [email protected])

    if(!b.IsEmpty())
    {
        acct[i].name = b[0];  <<---keeps failing in this assignment. 

     acct[i].email = b[1];
    system.debug('acct' + acct[i]);    
       p2.add(acct[i])  <--------- 
    }


}
insert p2;

The code keeps failing at the assignment to **acct[i].name = b[0]** saying List index out of bounds... . I don't get how can I assign multiple accounts to a variable. or a list to a list [b is also a list and acct is also a list]. What am trying to achieve is from the split list get account name and email assign to new list -- this needs to be looped through several data in that split array. Now capture all these new assigned values and insert in system using p2. Please advise. Also please excuse me as I'm still getting used to Apex.

Answer 1

Try this:

string [] email= new string[]{'[email protected]','[email protected]'};

    list<account> a= new list<account>();

for(integer i=0;i<email.size();i++)
    {
        account acc= new account();

        acc.name=email[i].split('-')[0];
        acc.email__c=email[i];
        a.add(acc);
    }

insert a;

Answer 2

Your list instantiation does not appear to be correct, as you need parentheses. The type you are using is also incorrect, as it is Account, not Accounts. Unless you have some custom class called accounts?

List<Account> p = new List<Account>();

As for the index error, you will not get any errors if you iterate through the elements like so:

for (Account acct : accountList)
{
    // do stuff
}

It won't do anything with an empty list, but you need to populate it somehow and that is outside the scope of your question.

Also, there is no sObject method called split so it is not clear what you are trying to accomplish there.

Answer 3

It does have several errors in your code. You use the p[i] before the p list still have no any elements, that's why you got the "index out of bounds" error. I did some change for your code, hope to help you:

List<String> emails = {'[email protected]','[email protected]'};
List<account> p = new list<account>;

for (i=0;i < emails.size();i++)
{
    Account acct = new Account();
    acct.name = emails[i].split('__')[0]
    acct.email = emails[i];
    p.add(acct);
}

insert p;