Apex: Ternary operator and SonarQube warning

Question

I have the following Boolean assignemnt:

Contact currentContact = new Contact();

currentContact.Is_Manager__c = UserWrapper.isManager() != null ? UserWrapper.isManager() : false;

UserWrapper class has isManager() method that can return either True, False or Null. CurrentContact.Is_Manager__c should either be true or false, not null.

I'm getting "Remove the unnecessary Boolean literal" warning in Sonarqube due to the 'false' in the ternary operator. Is this expected?

Answer 1

I think you meant UserWrapper.isManager() in both instances, rather than User.isManager(). Maybe that's causing the confusing error?

That said, there's a more modern way to write your code, assuming SonarQube supports it:

currentContact.Is_Manager__c = UserWrapper.isManager() ?? false;

The new null coalescing operator greatly improves code readability.

In any case, if the code was just a typo (we all do that from time to time), consider submitting a bug to SonarQube regarding the behavior.