UnusedLocalVariable Salesforce

Question

I am trying to resolve some of PMD warnings in Apex (Salesforce), currently I am working on this one UnusedLocalVariable and here is the code snippet where the problem is:

DateTime startDate = startDateOne;
String getData = 'SELECT data ' + 'FROM table ' + 'WHERE date = :startDate'

so..the problem is varible startDate is defined and used in query but it looks like the scanner can not recognize it because it is in a string 'WHERE date = :startDate', does anyone have an idea how to fix this?

Thanks in advance.

Answer 1

If you have to use dynamic SOQL like this, you'll need to ask PMD to suppress this "false positive". On the other hand, if you can use static SOQL that should avoid the issue:

DateTime startDate = startDateOne;
List<Table> records = [SELECT data FROM Table WHERE date = :startDate];

If you are dynamically defining the "data" or "table", you'll clearly need to stay using dynamic SOQL and tell PMD to suppress the false positive. There are a few different ways to do this.

I haven't tried it myself, but you could try:

@SuppressWarnings('PMD.UnusedLocalVariable')
theMethodSignature here() {
    DateTime startDate = startDateOne;
    String getData = 'SELECT data ' + 'FROM table ' + 'WHERE date = :startDate'

If that's too heavy handed, you can use the more targeted:

DateTime startDate = startDateOne; // TURN_OFF_WARNINGS
String getData = 'SELECT data ' + 'FROM table ' + 'WHERE date = :startDate'

As per feedback, the comment may need to be // NOPMD instead of // TURN_OFF_WARNINGS.

See the documentation for more details.