Unexpected token: 'Map' for method that returns a Map

Question

Trying to create a method to return a Map of SObjects using any field I want (not Id or I would use the Map constructor that takes a List).

private static Map<String, SObject> getSObjectMap(List<SObject> records, String fieldName) {
  String sObjectTypeString = String.valueOf(records[0].getSObjectType());
  Type t = Type.forName('Map<String,' + sObjectTypeString + '>');
  Map<String, SObject> mapRecords = (Map<String, SObject>) t.newInstance();
  for (SObject record: records) {
    String key = (String) record.get(fieldName);
    mapRecords.put(key, record);
  }
  return mapRecords;
}

REVISED (per Derek F) Map variable name from "map" to "mapRecords" to resolve "Unexpected token: Map" and "Expecting ';' but was ','" and "Unexpected token: map" for the second line.

Answer 1

map is a keyword, and it cannot be used as an identifier (the name of a variable, method, etc...).

Chose a different name for your variable, update the lines of code which use that variable, and you should be fine.

+edit:

To be a bit more specific, you can't use a reserved word (loop, and, map, etc...) as an identifier by itself, but it can be part of an identifier. myMap, ripAndTear, etc... There just needs to be something to prevent the compiler (parser?) from thinking it's something it isn't.