when approval process is modified what happens the old records which are locked?

Question

I have old approval process in which there are 3 approval steps and I created new approval process entirely same as old approval except I removed one approval step and i deactivated old approval and activated new approval.whenever old records which are in locked state I am trying to approve means it was firing old approval process where as when I tested by creating a new record means there are no issues is there any idea how to achieve that old records which are in locked must use new approval process.

public static void sendPOCApproval(set<Id> setOppIds){
        System.debug('sendPOCApproval Line 1');
        List<Opportunity> listOpp =[SELECT Id, ownerid FROM Opportunity WHERE ID IN: setOppIds];
        List<Approval.ProcessSubmitRequest> listOfApprovalRecords = new List<Approval.ProcessSubmitRequest>();
        System.debug('sendPOCApproval Line 2');
        if(!listOpp.isEmpty()){
            System.debug('sendPOCApproval Line 3');
            for(Opportunity opp :  listOpp){
                system.debug('opp.::');
                System.debug('sendPOCApproval Line 4');
                // Create an approval request for the opportunity
                Approval.ProcessSubmitRequest req = new Approval.ProcessSubmitRequest();
                req.setObjectId(opp.id); 
                System.debug('sendPOCApproval Line 5');
                // Setting submitter of approval
                req.setSubmitterId(opp.OwnerId);
                System.debug('sendPOCApproval Line 6');
                // Submit the record to specific process 
                req.setProcessDefinitionNameOrId('POC_approval');
                System.debug('sendPOCApproval Line 7'); 
                req.setSkipEntryCriteria(true);
                //Adding approval requests to a list
                listOfApprovalRecords.add(req);
                System.debug('sendPOCApproval Line 8');
            }
            System.debug('sendPOCApproval Line 9');
            // Submit the list of approval requests for the opportunity
            if(!listOfApprovalRecords.isEmpty() && !Test.isRunningTest()){
                System.debug('sendPOCApproval Line 10');
                System.debug('listOfApprovalRecords.Size()'+listOfApprovalRecords.size());
                List<Approval.ProcessResult> result = Approval.process(listOfApprovalRecords);
            }
            System.debug('sendPOCApproval Line 11');
        }
        System.debug('sendPOCApproval Line 12');
    }

Answer 1

This link from apex developer guide shows how to submit requests for approval processing and how to further approve them using apex code. You will first need to recall the approval requests on the records that are using the old approval process and then submit the same records for processing using the new approval process. Some of the records in intermediate stage also need to be handled via code.

To recall an approval process on a record, the code is pretty much the same as what is shown for approval processing in the developer guide, except that the following line of code needs to be replaced request.setAction('Approve'); with request.setAction('Remove');

Edited: Using the same code below you can fetch the opportunity records that have been locked by the old approval process and their current approval step.

List<Id> optyLockedByOldApproval = new List<Id>();
List<Id> lockedOptyIds = new List<Id>();
Map<Id, Boolean> lockedOptyRecords = Approval.isLocked(<Pass the Opportunity Record List here>);
for(Id optyId: lockedOptyRecords.keySet()){
    lockedOptyIds.add(optyId);
}
List<ProcessInstance> piList = [SELECT Id, TargetObjectId, ProcessDefinition.Id, ProcessDefinition.Name, ProcessDefinition.DeveloperName
                                FROM ProcessInstance 
                                WHERE ProcessDefinition.DeveloperName = '<Old Approval Process Name Here>'
                                    AND TargetObjectId IN :lockedOptyIds];
for(ProcessInstance pi: piList){
    optyLockedByOldApproval.add(pi.TargetObjectId);
}

List<ProcessInstanceNode> optyList = [SELECT ProcessInstance.TargetObjectId, Id, ProcessNodeId, ProcessNodeName, NodeStatus 
                                        FROM ProcessInstanceNode 
                                        WHERE ProcessInstance.TargetObjectId = :optyLockedByOldApproval];