How do we handle existing bad data on restricted picklist value

Question

I have a bunch of existing values for picklist and now we want to make the picklist as restricted picklist. Some of the records may contain values which are not in the restricted picklist.

I initially thought that by making a picklist restricted it wouldnt allow save of the record if it had a bad value. But it did allow edit and save even if there value in picklist is bad.

What could be the best way to make sure the users change the value before they save the record again?

1, Validation Rule : Its ok if the picklist is small but if picklist is in hundreds then its gonna be big VR.

2. Trigger

Any other way anyone can think of?

Answer 1

In addition to validation rules and triggers you also have the option of using a process builder flow or even a full flow to address this.

On the assumption that you can't automate the replacement of one bad value with one good value (this could be done as Pranay suggested I believe, or via a simple bit of anonymous apex with a bit of logic an SOQL query and a DML update), personally I would do this in a trigger, something like:

// First get the set of permitted values from the picklist, keeping just active ones
List<Schema.PicklistEntry> entries = Schema.SObjectType.SomeObject.fields.SomeField.getPicklistValues();

Set<String> permittedValues = new Set<String>();

for (Schema.PicklistEntry entry : entries) {
    if (entry.isActive()) {
        permittedValues.add(entry.getValue());
    }
}

// Now check each object given to the trigger
for (SomeObject someObject : Trigger.new) {
    if (!permittedValues.contains(someObject.SomeField)) {
        someObject.SomeField.addError('SomeField value must be changed as it is not valid (' + someObject.SomeField + ')');
    }
}

Answer 2

I can think of another way, not sure if this will fill your use case. In Restricted picklist add that bad value in metadata, and then click on delete,

SF will show a screen asking you to replace the old value with new value, which would be clean and from the restricted list.