Updating Apex failed: DmlException in (unrelated) Test

Question

I am trying to update the code of a Contact Trigger handler using the Force.com IDE. However, deploying does not work because of an error in an unchanged 3rd-party class.

Even if I uncomment all changes I get the following error on deployment in the Force.com IDE:

Test Results:

Run Failures: TelemarketingControllerTest.testNormalFlow System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, TargetX_Email.CampaignTrigger1: execution of AfterInsert

caused by: TargetX_Email.SecurityCheck.CRUDException: User does not have access to update Campaign

Class.TargetX_Email.SecurityCheck.crudError: line 73, column 1 Class.TargetX_Email.SecurityCheck.checkCRUD: line 60, column 1 Class.TargetX_Email.SecurityCheck.checkCRUD: line 43, column 1 Class.TargetX_Email.SecurityCheck.checkBoth: line 20, column 1 Class.TargetX_Email.SecurityCheck: line 10, column 1 Class.TargetX_Email.deleteFutureChildBroadcasts: line 99, column 1 Trigger.TargetX_Email.CampaignTrigger1: line 21, column 1: []
   Average test coverage across all Apex Classes and Triggers is 72%, at least 75% test coverage is required.

Somehow the test is triggering their code, it looks like.

And this is the offending line 31

@isTest
private class TelemarketingControllerTest {

     static testMethod void testNormalFlow(){
        //campaign
        Campaign testCampaign       = new Campaign();
        testCampaign.name           = 'TestCampaign';
        testCampaign.CallerTimeout__c = 'Null';
        testCampaign.Callbacks__c = '2 Callbacks';
        insert testCampaign; // << Line 31

I see the warning about the code coverage. But I guess the real problem is "User does not have access to update Campaign"

What can I do to avoid the problem and be able to deploy some changes to my Contact Trigger handler?

Answer 1

Rolling up from comment.

In case you are trying to create/update Campaigns, you need to make sure the User has Marketing User permission set. In this case, the User did not have the permission and thus was not able to create a Campaign record.

Refer to Who has access to campaigns? documentation which explains this behavior.

Depending on your sharing settings, users in your org can view campaigns, view the advanced campaign setup, or run campaign reports. However, only designated marketing users with the appropriate user permissions can create, edit, and delete campaigns and configure advanced campaign setup. An administrator must select the Marketing User option on a user’s personal information to designate that user as a marketing user.

Answer 2

You should not depend on real users's permission to test the block of code that needs a special permission.

Ideally you should create your own test user with marketing permission(UserPermissionsMarketingUser) to alter campaigns and campaign memebers. You can do that using System.runAs

@isTest
private class TelemarketingControllerTest {

     static testMethod void testNormalFlow(){
        //campaign

         // Setup test data
        // This code runs as the system user
        Profile p = [SELECT Id FROM Profile WHERE Name = 'Standard User'];
        User u = new User(Alias = 'standt', Email = 'standarduser@testorg.com',
                EmailEncodingKey = 'UTF-8', LastName = 'Testing', LanguageLocaleKey = 'en_US',
                LocaleSidKey = 'en_US', ProfileId = p.Id,UserPermissionsMarketingUser=true,
                TimeZoneSidKey = 'America/Los_Angeles', UserName = 'standarduser@testorg.com');

            System.runAs(u) {   
            Campaign testCampaign       = new Campaign();
            testCampaign.name           = 'TestCampaign';
            testCampaign.CallerTimeout__c = 'Null';
            testCampaign.Callbacks__c = '2 Callbacks';
            insert testCampaign; // << Line 31
        }
    }
}

Using run as will ensure, that no matter if the test running user does/does not have permission your test will execute.

Src: https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_tools_runas.htm