Trigger on Standard cross object field updates

Question

I want to Update Website(custom field) in opportunity by filling the same value in Website(standard field) in Account.Here by entering the value in Account website it should populate in the opportunity website field with same value.using trigger how can i do thistrigger

accountTrigger on Account (after Insert, after Update) { 
    List <Account> acc = new <Account>(); 
    acc = trigger.new(); 
    List <Opportunity> opp; 
    for(Account acc:acclist) { 
        opp=[select id,Website__c from Opportunity where Account id=acc.id]          
        for(Opportunity op:opp) { 
            op.Website__c=ac.Website; 
        } 
     }
 }

Answer 1

You should not put your SOQL inside of a for loop, because you will hit governor limits as soon as your list of Accounts becomes larger than 100. See Understanding Execution Governors and Limits for more info on governor limits.

You can use the Trigger.newMap's keySet to query for all of the Opportunities and then update them. You can take advantage of the fact that the Account that you query back as part of the Opportunity query will have the new value set at the time of the after update.

Note that you do not have to handle after insert, since it will be impossible for Opportunities to exist at the time that their parent Account is being inserted.

trigger AccountTrigger on Account (after update) {
    List<Opportunity> opps = [
        Select Id, Website__c, Account.Website
        From Opportunity
        Where AccountId In :Trigger.newMap.keySet()
    ];
    for (Opportunity opp : opps) {
        opp.Website__c = opp.Account.Website;
    }
    update opps;
}

Sidenote: You could also just query using Trigger.new directly and not use Trigger.newMap.keySet() as it is legal syntax to use a list of sObjects with IDs as part of an In clause. So you could have the following as your where clause. Either one will work.

Where AccountId In :Trigger.new

Answer 2

I don't think any need for trigger in this case, Cross object formula will do the task here.