Hot do I fetch correct id from contact rows after edit and save record

Question

Visualforce page which generates accounts and contacts. I can edit the record contact field, when I use the save button. It does not save my update to the corresponding record. My debug log outputs the complete list of accounts.

Visualforce:

<apex:page controller="actocons" tabStyle="Account">
    <apex:form >
        <apex:pageBlock mode="inlineEdit">
            <apex:pageBlockButtons >
                <apex:commandbutton value="save" action="{!save}"/>
            </apex:pageBlockButtons>

            <apex:repeat value="{!acct}" var="a">
                <apex:pageBlockSection id="section1" title="{!a.name}" onclick="document.getElementById(‘{!$Component.section1}’).childNodes[0].childNodes[0].click();">  
<script>twistSection(document.getElementById(“{!$Component.section1}').childNodes[0].childNodes[0]);document.getElementById(“{!$Component.section1}').childNodes[0].style.cssText = “cursor:pointer;' </script>
                    <apex:outputField value="{!a.Name}"/>
                    <apex:pageBlockTable value="{!a.Contacts}" var="c" id="j1">
                        <apex:column value="{!c.id}" />
                        <apex:column value="{!c.lastname}"/>
                        <apex:column value="{!c.lastname}"/>
                    </apex:pageBlockTable>
                </apex:pageBlockSection>
            </apex:repeat>
        </apex:pageBlock>
<script>
twistSection = (function() {
    var cached_function = twistSection;
    return function(twisty, sectionId) {
        cached_function.apply(this, arguments); // use .apply() to call the original twistSection function provided by Salesforce
        if (event.stopPropagation) {
            event.stopPropagation();
        } else {
            event.cancelBubble = true;
        }
    };
}());

</script>
    </apex:form>
</apex:page>

Controller:

public class actocons

{

    Private Id accID;
    public List<Contact> contactList{get;set;}


    public list <contact> myContact {set;get;}
    public list<account> acct{set;get;}
    public actocons()
    {
        acct=[select id,name,(select id,lastname from contacts)from account limit 5];
        myContact = [SELECT Id, Name FROM Contact WHERE Id = :ApexPages.currentPage().getParameters().get('id')];
    }

    public PageReference save() {


        contactList = new List<Contact>();
        accID=  ApexPages.currentPage().getParameters().get('acId');
        contactList =  [SELECT FirstName,LastName,Email,Phone FROM Contact WHERE AccountID = : accID];

        system.debug('contactList '+ contactList);
        update contactList;
        return null;
    }

}

Answer 1

About the only issue I can see is that your Visualforce page is showing a.Contacts (via a pageBlockTable), but your controller is running a separate query for Contact records in your save() method.

If the changes you're making to the Contacts on your Visualforce page are being tracked anywhere (and I don't know if they are. That usually requires using <apex:inputField>, and I don't know if setting the inlineEditing mode is enough), it would be in acct.Contacts.

Without writing up a Visualforce page of my own (I don't have time for that right now), my only suggestion would be to make the following changes to your controller's save() method:

public PageReference save() {

    contactList = new List<Contact>();

    // If you did need to query for Contacts, you could simply fetch the Id from
    //   one of the Accounts you're keeping in the variable `acct` (which itself
    //   could stand to be better named).
    //accID=  ApexPages.currentPage().getParameters().get('acId');
    //contactList =  [SELECT FirstName,LastName,Email,Phone FROM Contact WHERE AccountID = : accID];

    //system.debug('contactList '+ contactList);

    // Since the changes you make via your page will be stored in the 'Contacts'
    //   list associated to each Account, that's the Contacts you'll want to update.
    // We'll need to fetch the Contacts, and put them all into a single list.
    // Have I mentioned that acct is a really bad name for a list of Accounts?
    // I'd personally, at the very least, make the variable name plural (i.e. accts)
    //   if not putting 'List' in the variable name (e.g. accountsList)
    for(Account accnt :acct){
        // We use the child relationship name to access the List of Contacts related
        //   to the current Account.
        // In this case, that's 'Contacts'.
        // Since that gives us a `List<Contact>` as a result, we can't just use
        //   the List.add() method (which is for adding a single record).
        // Instead, we need to use addAll() (which accepts a List as an argument).
        contactList.addAll(accnt.Contacts);
    }

    update contactList;
    return null;
}