Lightning Component for quick action

Question

I built a lightning component to make some changes to Lead Record and I added it as a quick action.

This is my helper.js:

changeOwnerAction : function(cmp,event) {

    var recordId = cmp.get("v.recordId");

    var action = cmp.get("c.changeOwnerForSelectedRecord");

    action.setParams({
        recordId : recordId
    });

    action.setCallback(this,function(res){
        var state = res.getState();
        if(state === "SUCCESS"){
            //do something
        }
    });

    $A.enqueueAction(action);
},

closeAction: function(cmp, event){ 
    var recordId = cmp.get("v.recordId");
    var sObectEvent = $A.get("e.force:navigateToSObject");
        sObectEvent .setParams({
        "recordId": recordId,
        "slideDevName": "detail"
    });
    sObectEvent.fire(); 
}

And the controller calls those functions one after another:

doInit : function(component, event, helper) {
    helper.changeOwnerAction(component,event);
    helper.closeAction(component,event);
}

The doInit is used in an handler:

<aura:handler name="init" value="{!this}" action="{!c.doInit}" />

At the end of the action the modal still shows for just a second but I've to wait few seconds to get the update available in the detail view as well as in the Lead state wizard.

has anyone else faced this issue?

Answer 1

I think its a performance issue. Both are running synchronously and waiting for each other too load. I suggest if you could put "this.closeAction" inside the SUCCESS clause of the changeOwnerAction so it would only close once server call has returned the successful results and remove it from the controllerJS. Improvement might be negligible but its an enhancement on the threading process.

Answer 2

I understand that what you want is for this action to fire immediately upon clicking the button. However the way you've implemented it is not really considered good practice - the mere act of loading the component triggering a database update. https://developer.salesforce.com/page/Lightning_Security

Cross Site Request Forgery

In order to prevent CSRF attacks, do not invoke any server-side controller method that performs a DML operation automatically as the result of a page load. Specifically, do not invoke server-side DML controller method as onInit handlers, or afterRender handlers (if rendering is performed automatically on page load).

I have a similar use case in one client site where I wanted a Lightning Experience button to immediately execute Apex. What I did in the end was make a small Lightning component the size of a button, and used SLDS to style it as Lightning button. In App Builder I embedded that component as the topmost element of the sidebar in the Lightning layout. It's not in the same row as the other buttons but it still looks pretty natural. Clicking that component button instantly executes the desired Apex code with no modal, and the callback refreshes the Lightning record page.