update field when a changed is made

Question

I have this class wherein if the Accountid is not equal to contactID it should update the enddate to today. the problem is that it doesn't update the enddate to today date

    public with sharing class AccountContactChangeClass {

public static void AccountContactChange (map<Id, Contact> acctChangeContactsMap){
List<Accountcontactrelation> acccn;
System.debug('Test1 = ' + acccn);
if(acctChangeContactsMap!= null){
List<Accountcontactrelation> acrn  = New List<Accountcontactrelation>([SELECT AccountId,ContactId,CreatedById,CreatedDate,CurrencyIsoCode,EndDate,Id,IsActive,IsDeleted,IsDirect,LastModifiedById,LastModifiedDate,Roles,StartDate,SystemModstamp FROM AccountContactRelation where contactid in : acctChangeContactsMap.keyset()]); 
   System.debug('Test2 = ' + acrn);
   for (Accountcontactrelation arnt : acrn){
       if(arnt.accountid != acctChangeContactsMap.get(arnt.contactid).account.id)
       {
       arnt.enddate = system.today();
       System.debug('Test5 = ' + arnt);
       acccn.add(arnt);
       System.debug('Test6 = ' + arnt);
       }

    }
    update acccn;
    System.debug('Test8 = ' + acccn);

}
}}

Answer 1

You had a number of minor issues, outlined in your code, revised with comments.

public with sharing class AccountContactChangeClass {
    public static void AccountContactChange (map<Id, Contact> acctChangeContactsMap){
        // Always initialize your variables
        List<Accountcontactrelation> acccn = new List<AccountContactRelation>();
        // Don't have pointless debug messages --> // System.debug('Test1 = ' + acccn);

        // If the map was null, why did you bother calling this method?
        // if(acctChangeContactsMap!= null) {

        // The result of a query is already a list.
        // Also, you literally only need two fields. Do not query unused fields.
        List<Accountcontactrelation> acrn = 
            [SELECT AccountId, ContactId 
             FROM AccountContactRelation 
             where contactid in : acctChangeContactsMap.keyset()];
        for (Accountcontactrelation arnt : acrn) {
            // I strongly suspect that Account.Id is null. Use AccountId instead.
            // Do not use a relationship to get Id from a parent record.
            if(arnt.accountid != acctChangeContactsMap.get(arnt.contactid).AccountId) {
                arnt.enddate = system.today();
                acccn.add(arnt);
            }
        }
        update acccn;
    }
}

Your primary issue was that you were using Account.Id when you almost certainly meant to use AccountId.

Answer 2

Ok, there were some syntax mistakes in your code, and I have tried to fix them. Please try the below code.

public with sharing class AccountContactChangeClass {
public static void AccountContactChange (map<Id, Contact> acctChangeContactsMap){
    List<AccountContactRelation> acccn = List<AccountContactRelation>();
    System.debug('Test1 = ' + acccn); 
    if(acctChangeContactsMap!= null){ 
        List acrn = New List([SELECT AccountId,ContactId,CreatedById,CreatedDate,
                                CurrencyIsoCode,EndDate,Id,IsActive,IsDeleted,IsDirect,LastModifiedById,LastModifiedDate,Roles,
                                StartDate,SystemModstamp FROM AccountContactRelation 
                                where contactid in : acctChangeContactsMap.keyset()]); 
        System.debug('Test2 = ' + acrn); 
        for (Accountcontactrelation arnt : acrn){ 
            if(arnt.accountid != acctChangeContactsMap.get(arnt.contactid).accountId) { 
            arnt.enddate = system.today(); 
            System.debug('Test5 = ' + arnt); 
            acccn.add(arnt); 
            System.debug('Test6 = ' + arnt); 
            }
        }   
        update acccn;
        System.debug('Test8 = ' + acccn);
    } 
}}  

Now please pass the correct map into this class's method from your batch class, and try to test.

Hope this helps :)

Answer 3

Thanks everyone!

public with sharing class AccountContactChangeClass { public static void AccountContactChange (map acctChangeContactsMap){ List acccn = new List(); List acrn = [SELECT AccountId, ContactId FROM AccountContactRelation where contactid in : acctChangeContactsMap.keyset()]; System.debug('Test2 = ' + acrn); for (Accountcontactrelation arnt : acrn){ if(arnt.accountid != acctChangeContactsMap.get(arnt.contactid).accountId) { arnt.enddate = system.today(); System.debug('Test5 = ' + arnt); acccn.add(arnt); System.debug('Test6 = ' + arnt); } }
update acccn; System.debug('Test8 = ' + acccn); } }