How to write a trigger with two addError conditions at different places on the same record?

Question

Sample Trigger:

trigger AccTrigger2 on Account (before insert) {

    //Condition I am adding and this should run before the other condition.
    for(Account accObj: Trigger.new){
        if(accObj.Name.equalsIgnoreCase('Test')){
            accObj.addError('Name cannot be test');
            return;
        }
    }

    //Condition already present in the system
    for(Account accObj: Trigger.new){
        if(accObj.BillingState.equalsIgnoreCase('MA')){
            accObj.addError('Please select different state');
        }       
    }

}

Below records are coming into the trigger:

1. Name = 'Test', BillingState = 'CA'
2. Name = 'Test', BillingState = 'MA'
3. Name = 'Acme', BillingState = 'MA'
4. Name = 'Acme', BillingState = 'CA'

Output I am trying achieve:

Output 1(with return statement in the trigger):

Output 2(with return statement commented):

Question: Is there a way to update the trigger so that I can get the output I need. I cannot update the two conditions as one logic as the logic for each condition is very complex and we don't want to touch the existing logic.

Answer 1

You could use a map and use the sObjects themselves as keys, eg:

Map<Account,String[]> accountErrors = new Map<Account,String[]>();

for(Account accObj: Trigger.new){
    if(accObj.Name.equalsIgnoreCase('Test')){
        if (!accountErrors.containsKey(accObj)){
          accountErrors.put(accObj,new String[]{'Name cannot be test'});
        }
        else {
          accountErrors.put(accObj,accountErrors.get(accObj).add('Name cannot be test'));
        }
    }
}

//Condition already present in the system
for(Account accObj: Trigger.new){
    if(accObj.BillingState.equalsIgnoreCase('MA')){
        if (!accountErrors.containsKey(accObj)){
          accountErrors.put(accObj,new String[]{'Please select different state'});
        }
        else {
          accountErrors.put(accObj,accountErrors.get(accObj).add('Please select different state'));
        }
    }       
}

//finally loop the errors map:
for (Account acct : accountErrors.keySet()){
  String[] errors = accountErrors.get(acct);
  for (String err : errors){
    acct.addError(err);
  }
}

You can extract the addition of errors to the map like so:

Map<Account,String[]> addCustomErrors(Map<Account,String[] accountErrors, Account accObj, String error){
    if (!accountErrors.containsKey(accObj)){
      accountErrors.put(accObj,new String[]{error});
    }
    else {
      accountErrors.put(accObj,accountErrors.get(accObj).add(error));
    }
    return accountErrors;

}

So inside your existing code you would only need to change:

accObj.addError('Name cannot be test');

To:

accountErrors = addCustomErrors(accountErrors,accObj,'Name cannot be test');

Answer 2

If you want to control order of precedence of trigger validations, you would need to adopt a pattern where you validate the collection, and then apply all validations on a record by record basis. What I mean by that is:

public with sharing class AccountService
{
    public static void validate(List<Account> records)
    {
        for (Account record : records) validate(record);
    }
    static void validate(Account record)
    {
        if (/*Condition 1*/)
        {
            record.addError('Message 1');
            return;
        }
        if (/*Condition 2*/)
        {
            record.addError('Message 2');
        }
    }
}