Summary Fields is not calculated in 1st attempt when using Inline Editing as well as Save Button

Question

I have a requirement inwhich I am calculating field 'Net revenue Impact' field of all Opportunity products and display it in Summary field 'Net Rev Impact on FY' on Opportunity Object.

Below is the apex code that I have written on OpportunityLineItem Trigger:

public with sharing class OpportunityLineItemServices {


    public static void getNetRevImpact(Id optId) {
        map<id,Decimal> oppidtoopplineitm =new map<id,Decimal>();
        Set<Id> opportunitiesId=new Set<Id>();
        list<Opportunity> finalOpportunity = new list<Opportunity>();
        Decimal sum=0.00;
        for(OpportunityLineItem lineItem:[Select Id,OpportunityId,Net_Rev_Impact_on_FY__c from OpportunityLineItem where OpportunityId=:optId ])
        {
            opportunitiesId.add(lineItem.OpportunityId);
            sum =(sum+lineItem.Net_Rev_Impact_on_FY__c).setScale(2);
            oppidtoopplineitm.put(lineItem.OpportunityId,sum);

        }

        Map<Id,Opportunity> idToOpportunity=new Map<Id,Opportunity>([SELECT Id,Net_Rev_Impact_on_FY__c FROM Opportunity WHERE Id =:opportunitiesId]);
        for(id oId: oppidtoopplineitm.keyset()){
            idToOpportunity.get(oId).Net_Rev_Impact_on_FY__c = oppidtoopplineitm.get(oId);
            finalOpportunity.add(idToOpportunity.get(oId)); 
        }
        update finalOpportunity;
  }

This code is working fine.When I add or Update or delete a product,it calculates accordingly and display it Summary field.

But I have a additional requirement inwhich when I change the ContractStartDate or ContractEndDate on Opportunity Object then it should calculate all the products accordingly and Update the Summary Field. For this I have written another same piece of code on Opportunity Trigger:

public static void getNetRevImpactOpp(Opportunity opt) {
    map<id,Decimal> oppidtoopplineitm =new map<id,Decimal>();
    list<Opportunity> finalOpportunity = new list<Opportunity>();
    Decimal sum=0.00;

    for(OpportunityLineItem lineItem:[Select Id,OpportunityId,Net_Rev_Impact_on_FY__c from OpportunityLineItem where OpportunityId=:opt.Id ])
    {
        sum =(sum+lineItem.Net_Rev_Impact_on_FY__c).setScale(2);
        oppidtoopplineitm.put(lineItem.OpportunityId,sum);

    }  
    for(id oId: oppidtoopplineitm.keyset()){

        opt.Net_Rev_Impact_on_FY__c = oppidtoopplineitm.get(oId);

    }

When I Change the ContractStartDate or ContractEndDate,it does not update the value in OpportunityLineItem and due this it does not show the correct value in Summary field.But when I click on refresh button,it displays the correct result which is strange. I have tested the functionality 15 days before and it was working absolutely fine.But I am not sure what has suddenly updated in salesforce that cause this weird issue.

Anybody has an idea?

What modification needs to be done in this code..

Answer 1

You should share more of your code - are you triggering on before or after update? Is the field you are reading a formula field or regular currency field? That said, I did notice one thing: your second code block has no DML statements, so there's nothing there that would update the database, assuming it's an after trigger. Your first code block has this:

update finalOpportunity;

Now, like I said, there are more factors at play - for example, if your trigger is running in a before update context, you can modify the field values before the record is committed to the database and there is no need to call update on those records. However, if you are in an after update context on your opportunity trigger, and then you are updating the opportunity again in that trigger, you'll need to use a static variable to keep track of whether you have already processed the record in this execution context to prevent a recursive loop that will eventually cause your trigger to fail with a governor limit exception.

Another issue I see in your OpportunityLineItemServices is that it only takes a single opportunity ID and then performs two SOQL queries and an update on that opportunity which means that your trigger is not properly bulkified. Trigger.new can contain up to 200 records a pop, you'll get an exception after 101 SOQL statements, and your trigger will hit that limit with just 50 records in the best-case scenario.

It's good that you are using maps and what look like handler classes but you have to implement some flow control and bulkify your code or I promise it will cause you problems.

And if you want really good answers, you'll need to include information, because honestly nobody can tell you why your code isn't working based on what you've provided. We need to see the rest of the code at least.

Answer 2

How do you know that there is no master child relationship between Opportunity and OpportunityLineItem.

Did you give any try?

Look below: