Help Insert trigger

Question

I have a simple trigger but I cannot figure out why it's not insert Account List Item records. Here is the code.

Trigger Eisai_createAcctListItem on Affiliation_vod__c (before insert){

    Set<String> affToAcctSet = new Set<String>();
    List<Account_List_vod__c> existingAcctList = new List<Account_List_vod__c>();
    List<Account_List_Item_vod__c> toInsertAcctListItem = new List<Account_List_Item_vod__c>();

    for(Affiliation_vod__c newAff: Trigger.New)
    {
        if(newAff.Parent_vod__c = false)
        {
            affToAcctSet.add(newAff.To_Account_Value__c);
        }   
    }

    existingAcctList = [SELECT Id, Name_Substring__c FROM Account_List_vod__c WHERE Name_Substring__c IN :affToAcctSet];

    for(Account_List_vod__c allAcctList: existingAcctList){
        for(Affiliation_vod__c affRec : Trigger.New)
        {
            Account_List_Item_vod__c AccListItem = new Account_List_Item_vod__c(
                                      Account_List_vod__c = allAcctList.Id,
                                      Account_vod__c = affRec.From_Account_vod__c
            );
            toInsertAcctListItem.add(AccListItem);
        }
    }

    Database.insert(toInsertAcctListItem,false));

}//end of trigger

Basically, what I want to happen is, after child affiliation record was inserted, the trigger should find the Account List record (Master) where Name_Substring__c is in the Set of named 'affToAcctSet' then will create Account List Item record (Details)

Answer 1

This may not fix your issue but it is an issue, I bet you affToAcctSet is null because per your comment so with that being said this will need to be an After Insert trigger, you will also have to look into Keiths answer. So as I said put in System.debug('affToAcctSet is null?' + affToAcctSet);

To add, I don't know your structure but if you move this to an After Insert/Update ..? You can use the id of the account, rather than relying on a String to do your query

Answer 2

Not exactly sure of the relationships but something like this may be what you are looking for:

Trigger Eisai_createAcctListItem on Affiliation_vod__c (before insert) {

    Set<String> names = new Set<String>();
    for (Affiliation_vod__c a: Trigger.New) {
        if (a.Parent_vod__c == false) {
            names.add(a.To_Account_Value__c);
        }   
    }

    // Only works if only 1 record per Name_Substring__c
    Map<String, Id> m = new Map<String, Id>();
    for (Account_List_vod__c> a : [
            SELECT Id, Name_Substring__c
            FROM Account_List_vod__c
            WHERE Name_Substring__c IN :names
            ]) {
        m.put(a.Name_Substring__c, a.Id);
    }

    List<Account_List_Item_vod__c> inserts = new List<Account_List_Item_vod__c>();
    for (Affiliation_vod__c a : Trigger.New) {
        if (a.Parent_vod__c == false) {
            Id id = m.get(a.To_Account_Value__c);
            if (id != null) {
                inserts.add(new Account_List_Item_vod__c(
                        Account_List_vod__c = id,
                        Account_vod__c = a.From_Account_vod__c
                        ));
            }
        }
    }
    Database.insert(inserts, false);
}