bestpractice for calling apex methods

Question

I have a class that calls to an apex method with in a for loop and that method in-turn calls other apex method. All the methods have SOQL's in them.

Running into 101 SOQL issue.

for(sobject obj:somelist) {
    apexclass1.mehtod1(obj);
}

public class apexclass1 {
    public void method1(obj) {
        List<Sobject> queryresults = [select id from sobject where id=:obj.Id];
        apexclass2.method2(queryresults.Id);
    }
}

public class apexclass2 {
    public void method2(Id) {
        List<Sobject> queryresults = [select id from sobject where id=:Id];
    }
}

I tried to bulkify the methods by eliminating loops and passing list<> instead of single record to methods. But I might end-up disturbing existing functionality somewhere.

What would be the better and safe approach now?

Answer 1

Collection are best way to avoid these situations. With minimum changes you can avoid SOQL query by bulkify as below:

Set<Id> objIDSet = new Set<Id>();
for(sobject obj:somelist )
{
    objIDSet.add(obj.id);   
}
apexclass1.mehtod1(objIDSet);


public class apexclass1
{
    public void method1(Set<Id> objIds)
    {
        Set<Id> queryresults = new Set<Id>();
        for(Sobject queryresult : [select id from sobject where id in: objIds])
        {
            queryresults.add(queryresult.Id);
        }
        apexclass2.method2(queryresults);
    }
}

public class apexclass2
{
    public void method2(Set<Id> recordIDs)
    {
        List<Sobject> queryresults = [select id from sobject where id in:recordIDs];

    }
}

However, above code has chain of for-loops. To avoid this you would change the class design. With this design above is solution.