best way to handler trigger Recursive call

Question

Below is my code snippet that I have used. And also I used static Boolean to handle the recursive call.

But when I update more than 200 records then trigger only process first 200 record not all the records after 200.

So I think this is not a best solution to use static Boolean variable.

So what will be the best solution for this ?

trigger RN_Account on Account (after update) 
{
    RN_AccountHandler handler = new RN_AccountHandler();
    if(Trigger.isAfter && Trigger.isUpdate && RN_AccountHandler.isUpdate)
    {
        RN_AccountHandler.isUpdate = false;
        handler.onAfterUpdate(Trigger.newMap, Trigger.OldMap);
    }
}

Handler

public with sharing class RN_AccountHandler 
{
    public static Boolean isUpdate = true;
    public void onAfterUpdate(map<Id, Account> mapNewAccount, map<Id, Account> mapOldAccount)
    {
        system.debug('========mapNewAccount.values()============'+mapNewAccount.values().size());
    }
}

I have added RN_AccountHandler.isUpdate to handle the

Answer 1

So as @cropredy suggested using static map instead this is what I tried. I used static set to solve this issue.

I can't say this is the best solution or not but this is working.

may me some usecases will be there please feel free to comment on this post.

So I used set of Id static variable.

Trigger

trigger RN_Account on Account (after update) 
{
   RN_AccountHandler handler = new RN_AccountHandler();

   if(Trigger.isAfter && Trigger.isUpdate && !RN_AccountHandler.setAccountIds.containsAll(Trigger.newMap.KeySet())) 
   { 
      RN_AccountHandler.setAccountIds.addAll(Trigger.newMap.KeySet());
      handler.onAfterUpdate(Trigger.newMap, Trigger.OldMap);
    }
}

Handler

public with sharing class RN_AccountHandler 
{   
    public static set<Id> setAccountIds = new set<Id>();

    public void onAfterUpdate(map<Id, Account> mapNewAccount, map<Id, Account> mapOldAccount)
    {
       system.debug('====11========='+mapNewAccount.values().size());
       update [SELECT Id, Name FROM Account WHERE Id IN: mapNewAccount.keyset()];
    }
}

One more solution

IN controller after execution just make the boolean to true

Trigger

trigger RN_Account on Account (after update) 
{
    RN_AccountHandler handler = new RN_AccountHandler();
    if(Trigger.isAfter && Trigger.isUpdate && RN_AccountHandler.isUpdate)
    {
        RN_AccountHandler.isUpdate = false;
        handler.onAfterUpdate(Trigger.newMap, Trigger.OldMap);
    }
}

Controller

public with sharing class RN_AccountHandler 
{
    public static Boolean isUpdate = true;
    public void onAfterUpdate(map<Id, Account> mapNewAccount, map<Id, Account> mapOldAccount)
    {
        system.debug('============'+mapNewAccount.values().size());
        update [SELECT Id, Name FROM Account WHERE Id IN: mapNewAccount.keyset()];
        RN_AccountHandler.isUpdate = true;
    }
}

Answer 2

The only approach I know is to store a Set of Ids that have been processed already as @cropredy suggested. So the code will be something like this:

trigger RN_Account on Account (after update) 
{
    RN_AccountHandler handler = new RN_AccountHandler();
    if(Trigger.isAfter && Trigger.isUpdate)
    {
        RN_AccountHandler.isUpdate = false;
        handler.onAfterUpdate(Trigger.newMap, Trigger.OldMap);
    }
}

public with sharing class RN_AccountHandler 
{
    public static Set<Id> processedIDs = new Set<Id>();
    public void onAfterUpdate(map<Id, Account> mapNewAccount, map<Id, Account> mapOldAccount)
    {
        system.debug('========mapNewAccount.values()============'+mapNewAccount.values().size());
        for (Id accountId : mapNewAccount.keySet()) {
            if (!processedIDs.contains(accountId)) {
                // your code
                processedIDs.add(accountId);
            }
        }
    }
}

Answer 3

The issue is that you've put your public static boolean in your class instead of in your trigger. Your class is called from the trigger and needs to be called for every 200 records when the trigger is called the FIRST time. By putting the Boolean in your class, your preventing the class from running more than once per trigger invocation. Relocate your boolean as follows using an external trigger helper class to hold the boolean.

trigger RN_Account on Account (after update) 
{
   if(!triggerHelper.FirstRun){
      FirstRun = true; 
      RN_AccountHandler handler = new RN_AccountHandler();
      if(Trigger.isAfter && Trigger.isUpdate)
      {
          handler.onAfterUpdate(Trigger.newMap, Trigger.OldMap);
      }
    }
}


public with sharing triggerHelper class {

   public static boolean FirstRun = false;

}

When the trigger runs the SECOND time, the boolean will be true, causing the trigger to immediately exit.

Answer 4

You can do this:

public class RN_AccountHandler
{
    public static boolean isExecuting = false;

    public static void onAfterUpdate(map<Id, Account> mapNewAccount, map<Id, Account> mapOldAccount)
    {
        if( RN_AccountHandler.isExecuting )
        {
            // avoid recursion: if was executed during the same context 
            return;
        }

        RN_AccountHandler.isExecuting = true;

        // your code for after update logic
    }
}