Access List Element On Apex Repeat

Question

Below is my pathetic attempt at VF and Apex. The two are barely talking to one another. Let's get them to be friends. What do I need to change to get the variables in Mr. Controller to display in Mrs VF page. (I can just see the moderators rip me for this one. Stupid and annoying people do not do well on this list)

I need memTypes, orgs and eventually contact__r.Name to show in a HTML table on Mrs VF but first lets have the two pages talk without needing a lawyer. What does on the apex:repeat line and what goes on the apex:outputtext line?

Mrs. VF Page:

<apex:repeat value="{!orgs}" var="string" id="theRepeat">

    <apex:outputText value="{!orgs}" id="theValue"/><br/>

</apex:repeat>

Mr Controller page

public class vfCtrlr_BOG_Committee_Report {

    public String[] getOrgs() 
    {
        List bogQueryList = [Select BOG_Membership_Type_New__c, ORG__c, contact__r.Name 
        FROM BOG_Membership__c 
        WHERE BOG_Membership_Status__c = 'Active' 
        AND BOG_Membership_Type_New__c  '' 
        ORDER BY BOG_Membership_Type_New__c , ORG__c, contact__r.Name ];

        String[] memTypes = New List ();
        String[] orgs = New List ();    

        for(BOG_Membership__c record :bogQueryList)
        {
            memTypes.add((String) record.get('BOG_Membership_Type_New__c'));
            orgs.add((String) record.get('ORG__c'));
        }

        return orgs;

    }
}

Answer 1

Your Mrs. Visualforce page should be look like:

<apex:repeat value="{!orgs}" var="BOGMembership" id="theRepeatId">

    <apex:outputText value="{!BOGMembership}" id="theValue"/><br/>

</apex:repeat>

• Attribute value accept the List type variable.
  
• Attribute var is a reference variable to use during <apex:repeat> iteration. So, it can be any relevant name which make sense.

String can be directly used by expression as:

 <apex:repeat value="{!orgs}" var="BOGMembership" id="theRepeatId">

    <apex:outputText value="{!BOGMembership}" id="theValue"/><br/>

 </apex:repeat>

Below is refactored code:-

Mr. Controller:

public class vfCtrlr_BOG_Committee_Report {

    public BOG_Membership__c[] getOrgs() 
    {
        // Keep Unique MemTypes + record
        Map<String,BOG_Membership__c> uniqueRecords = new Map<String,BOG_Membership__c>();

        for(BOG_Membership__c bogm : [Select BOG_Membership_Type_New__c, ORG__c, contact__r.Name 
        FROM BOG_Membership__c 
        WHERE BOG_Membership_Status__c = 'Active' 
        AND BOG_Membership_Type_New__c  '' 
        ORDER BY BOG_Membership_Type_New__c , ORG__c, contact__r.Name ])
        {  

            uniqueRecords.put(bogm.BOG_Membership_Type_New__c+bogm.ORG__c,bogm);

        } 

        return uniqueRecords.values();

    }
}

The below lines

String[] memTypes = New List ();
        String[] orgs = New List ();    

        List repList = new List();
        for(BOG_Membership__c record :bogQueryList)
        {
            //memTypes.add((String) record.get('BOG_Membership_Type_New__c'));
            //orgs.add((String) record.get('ORG__c'));
            repList.add(new ReportWrapper((String) record.get('BOG_Membership_Type_New__c'),(String) record.get('ORG__c'),record.contact__r.Name));

        }

are useless as they are not doing anything accept adding field values in two separate lists from a single record. This can be done just by returning record. Instead directly return record and use on VF as:

<apex:repeat value="{!orgs}" var="BOGMembership" id="theRepeatId">

    <apex:outputText value="{!BOGMembership.BOG_Membership_Type_New__c}" /><br/>
    <apex:outputText value="{!BOGMembership.ORG__c}" /><br/>
    <apex:outputText value="{!BOGMembership.contact__r.Name}" /><br/>

</apex:repeat>

Answer 2

//You can try it by creating a wrapper class and returning list of that wrapper //class in the getter method 'getOrgs()'

Edit: As all the values are from the same object you don't need a wrapper object.

Something like;

public class vfCtrlr_BOG_Committee_Report {

  public List<BOG_Membership__c> getOrgs() 
    {
        return [Select BOG_Membership_Type_New__c, ORG__c, contact__r.Name 
        FROM BOG_Membership__c 
        WHERE BOG_Membership_Status__c = 'Active' 
        AND BOG_Membership_Type_New__c  '' 
        ORDER BY BOG_Membership_Type_New__c , ORG__c, contact__r.Name ];
    }
}

And modify your VF like;

<apex:repeat value="{!orgs}" var="org" id="theRepeat">

    <apex:outputText value="{!org.BOG_Membership_Type_New__c}"/> &-nbsp;&-nbsp;&-nbsp;
    <apex:outputText value="{!org.ORG__c}"/> &-nbsp;&-nbsp;&-nbsp;
    <apex:outputText value="{!org.contact__r.Name}"/> </br>
</apex:repeat>

Note: use correct symbol for html space instead of &-nbsp;