3

I am implementing a trigger to convert Lead records that have a status of 'Qualified'.

I was able to get a trigger working except it was creating new accounts for every lead converted, which we didn't want. In the Lead record the account name is stored as a string in the Company field. I want to select from accounts with Account.Name = Lead.Company so I can get the Account.ID and use the setAccountID() function to avoid creating new accounts.

What I have so far:

trigger LeadTrigger on Lead (after insert, after update) {
    LeadStatus convertStatus = [
        select MasterLabel
        from LeadStatus
        where IsConverted = true
        limit 1
    ];

    List<Database.LeadConvert> leadConverts = new List<Database.LeadConvert>();
    for(Lead tLead : Trigger.new) {
        String accName = tLead.Company;

        Account accountId = [
            select Id from 
            Account where Account.Name = ':accName' and Account_External_Id__c != null 
            limit 1
        ];
        // and Account_External_Id__c != null
        if((!tLead.isConverted && tLead.Status== convertStatus.MasterLabel)) {
            Database.LeadConvert lc = new Database.LeadConvert();
            //String oppName = lead.Name;
            lc.setAccountId(accountId.Id);
            lc.setLeadId(tLead.Id);
            lc.setDoNotCreateOpportunity(True);
            lc.setConvertedStatus(convertStatus.MasterLabel);

            leadConverts.add(lc);
        }
    }
    If(!leadConverts.isEmpty()) {
        List<Database.LeadConvertResult> lcr = Database.convertLead(leadConverts); //convert the leads
    }
}

No matter what I try the select from Accounts gives me a fatal error:

FATAL_ERROR System.QueryException: List has no rows for assignment to SObject

... And returns no records. I know there are records in the Account object for the Company name, I've even tried hard coding values into the query.

  • This trigger is not bulkified, you may think that only 1 Lead will ever be converted per transaction but SFDC supports bulk Lead Conversion through APIs and Apex. best to get in the habit of bulkifying all triggers – cropredy Dec 10 '15 at 17:47
4

Change this:

Account.Name = ':accName'

to this:

Name = :accName

so your entire query would be:

Account accountId = [
      SELECT Id, Name FROM 
      Account WHERE Name = :accName AND Account_External_Id__c != null 
      LIMIT 1
  ];

saying = ':accName' is looking for Accounts with the literal value ":accName" since you wrapped it in single quotes. You don't need single quotes around SOQL bind variables.

You should not have this SOQL query within your for loop - please see Apex best practices. For every iteration of your loop, you will accrue a SOQL query - this will quickly hit governor limits in any type of bulk scenario.

  • I changed it to where Name = :accName but it's still not returning anything and I get the same error message – Cory Dec 10 '15 at 17:05
  • Beat me to it! Does it work @Cory? – Dan Jones Dec 10 '15 at 17:06
  • Unfortunately, it's still not returning any records... – Cory Dec 10 '15 at 17:07
  • Comments are not for extended discussion; this conversation has been moved to chat. – Samuel De Rycke Dec 16 '15 at 9:56

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.