Combining DML, Callouts and Triggers gives CalloutException

Question

When running unit tests, I'm currently getting:

System.CalloutException: You have uncommitted work pending. Please commit or rollback before calling out

The issue is that I have a trigger that runs a callout after account update. So I need to set the mock callout before anything would update the account. The current test works if I comment out the second custom object logic (i.e. the second line would cause the trigger to fire again). However, if I send update accounts two separate times, it throws the above error.

My current approach is the following:

static testMethod void testNow() {
    Test.startTest();
    Test.setMock(HttpCalloutMock.class, new ThisIsMyMockCallout());

    List<Account> testAccs = makeNewAccounts(1,10); // Makes list of 1 account
    insert testAccs; // This works without mock since it doesn't update acc

    List<CustomObject> customObjs = makeNewCustomObs(testAccs);
    insert customObjs; // This needs mock as it updates account due to relation

    List<CustomObjectA> customObjsA = newMakeCustomObsA(customObjs,testAccs);
    insert customObjsA; // This needs mock as it updates account due to relation
    Test.stopTest();
    // A bunch of assertEquals tests
}

Any help would be great!

Answer 1

It appears to me, the issue that you're having is because of where you've located Test.startTest() in your test method. As I understand your description, you're still creating test data at the beginning of your method.

static testMethod void testNow() {

    Test.setMock(HttpCalloutMock.class, new ThisIsMyMockCallout());

    List<Account> testAccs = makeNewAccounts(1,10); // Makes list of 1 account
    insert testAccs; // This works without mock since it doesn't update acc

    Test.startTest();
    List<CustomObject> customObjs = makeNewCustomObs(testAccs);
    insert customObjs; // This needs mock as it updates account due to relation

    List<CustomObjectA> customObjsA = newMakeCustomObsA(testAccs);
    insert customObjsA; // This needs mock as it updates account due to relation
    Test.stopTest();
    // A bunch of assertEquals tests
}

That having been said, it also appears that the last two lines, you reference need the mock because they update the relation and fire the trigger. Each would fire the trigger separately. If that's the case, you would presumably use two methods to cover the testing of your trigger; one for each of these. The first method would cover the insert of customOjbs and the 2nd method would cover the insert of customObsA.

The above assumes they don't need to be in the order you have them in your test method. If they do, then I believe you'd need to begin Test.startTest in your final test class after the insert of customObjs rather than before, using the mock as a response to it before the insert of the final list of records.